Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(executor): Make docker executor more robust. #5363

Merged
merged 3 commits into from
Mar 11, 2021
Merged

fix(executor): Make docker executor more robust. #5363

merged 3 commits into from
Mar 11, 2021

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Mar 11, 2021

No description provided.

@alexec
fix(executor): Make docker executor more robust
b41718a 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec added this to the v3.0 milestone Mar 11, 2021
@alexec
fix(executor): Make docker executor more robust
dbf87a2 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
fix(executor): Make docker executor more robust
d271fbd 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec marked this pull request as ready for review March 11, 2021 18:48
@alexec alexec requested a review from whynowy March 11, 2021 18:48
@alexec alexec changed the title fix(executor): Make docker executor more robust fix(executor): Make docker executor more robust (v3.0.0) Mar 11, 2021
@alexec alexec changed the title fix(executor): Make docker executor more robust (v3.0.0) fix(executor): Make docker executor more robust. (>= v3.0.0) Mar 11, 2021
@alexec alexec changed the title fix(executor): Make docker executor more robust. (>= v3.0.0) fix(executor): Make docker executor more robust. Mar 11, 2021
whynowy
whynowy approved these changes Mar 11, 2021
View reviewed changes
workflow/executor/docker/docker.go
if containerID == "" || d.containers[containerName] == containerID {
continue
}
if createdAt.Before(started.Add(-15 * time.Second)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 15 seconds the approximate start time?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct

@alexec alexec merged commit 9faae18 into argoproj:master Mar 11, 2021
@alexec alexec deleted the docker branch March 11, 2021 19:09
@simster7 simster7 mentioned this pull request Mar 15, 2021
Closed
27 tasks
simster7 pushed a commit that referenced this pull request Mar 16, 2021
@alexec @simster7
fix(executor): Make docker executor more robust. (#5363)
452b370
@simster7 simster7 mentioned this pull request Mar 29, 2021
Closed
77 tasks
@simster7 simster7 mentioned this pull request Apr 19, 2021
Closed
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whynowy whynowy whynowy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alexec @whynowy